Remove dev-only status mock; always query Midtrans API. Add helper script to compute Midtrans webhook signature for local tests.
This commit is contained in:
parent
6472e95310
commit
80fb683dcc
|
|
@ -0,0 +1,15 @@
|
|||
// Utility to compute Midtrans webhook signature: sha512(order_id + status_code + gross_amount + server_key)
|
||||
const crypto = require('crypto')
|
||||
|
||||
function main() {
|
||||
const [orderId, statusCode, grossAmount, serverKey] = process.argv.slice(2)
|
||||
if (!orderId || !statusCode || !grossAmount || !serverKey) {
|
||||
console.error('Usage: node scripts/midtrans-sig.js <order_id> <status_code> <gross_amount> <server_key>')
|
||||
process.exit(1)
|
||||
}
|
||||
const raw = String(orderId) + String(statusCode) + String(grossAmount) + String(serverKey)
|
||||
const sig = crypto.createHash('sha512').update(raw).digest('hex')
|
||||
process.stdout.write(sig)
|
||||
}
|
||||
|
||||
main()
|
||||
|
|
@ -276,10 +276,14 @@ app.get('/api/payments/:orderId/status', async (req, res) => {
|
|||
if (isSuccessfulMidtransStatus(status)) {
|
||||
const nominal = String(status?.gross_amount || '')
|
||||
if (!notifiedOrders.has(orderId)) {
|
||||
notifiedOrders.add(orderId)
|
||||
activeOrders.delete(orderId)
|
||||
logInfo('status.notify.erp.trigger', { orderId, transaction_status: status?.transaction_status })
|
||||
await notifyERP({ orderId, nominal })
|
||||
const ok = await notifyERP({ orderId, nominal })
|
||||
if (ok) {
|
||||
notifiedOrders.add(orderId)
|
||||
} else {
|
||||
logWarn('erp.notify.defer', { orderId, reason: 'post_failed_or_missing_data' })
|
||||
}
|
||||
} else {
|
||||
logInfo('erp.notify.skip', { orderId, reason: 'already_notified' })
|
||||
}
|
||||
|
|
@ -466,18 +470,18 @@ function resolveMercantId(orderId) {
|
|||
async function notifyERP({ orderId, nominal, mercantId }) {
|
||||
if (!ERP_ENABLE_NOTIF) {
|
||||
logInfo('erp.notify.skip', { reason: 'disabled' })
|
||||
return
|
||||
return false
|
||||
}
|
||||
// Untuk notifikasi dinamis, hanya URL dan client secret yang wajib
|
||||
if (!ERP_NOTIFICATION_URL || !ERP_CLIENT_ID) {
|
||||
logWarn('erp.notify.missing_config', { hasUrl: !!ERP_NOTIFICATION_URL, hasClientId: !!ERP_CLIENT_ID })
|
||||
return
|
||||
return false
|
||||
}
|
||||
const statusCode = '200'
|
||||
const mId = mercantId || resolveMercantId(orderId)
|
||||
if (!mId) {
|
||||
logWarn('erp.notify.skip', { orderId, reason: 'missing_mercant_id' })
|
||||
return
|
||||
return false
|
||||
}
|
||||
const signature = computeErpSignature(mId, statusCode, nominal, ERP_CLIENT_ID)
|
||||
// Payload ERP harus flat: { mercant_id, nominal, status_code, signature }
|
||||
|
|
@ -491,8 +495,10 @@ async function notifyERP({ orderId, nominal, mercantId }) {
|
|||
try {
|
||||
const res = await postJson(ERP_NOTIFICATION_URL, payload)
|
||||
logInfo('erp.notify.success', { orderId, status: res.status })
|
||||
return true
|
||||
} catch (e) {
|
||||
logError('erp.notify.error', { orderId, message: e?.message })
|
||||
return false
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -518,12 +524,17 @@ app.post('/api/payments/webhook', async (req, res) => {
|
|||
|
||||
// Process success callbacks asynchronously
|
||||
if (isSuccessfulMidtransStatus(body)) {
|
||||
logInfo('webhook.success_status', { order_id: orderId, transaction_status: body?.transaction_status, fraud_status: body?.fraud_status })
|
||||
const nominal = String(grossAmount)
|
||||
if (!notifiedOrders.has(orderId)) {
|
||||
notifiedOrders.add(orderId)
|
||||
// Mark order inactive upon completion
|
||||
activeOrders.delete(orderId)
|
||||
await notifyERP({ orderId, nominal })
|
||||
const ok = await notifyERP({ orderId, nominal })
|
||||
if (ok) {
|
||||
notifiedOrders.add(orderId)
|
||||
} else {
|
||||
logWarn('erp.notify.defer', { orderId, reason: 'post_failed_or_missing_data' })
|
||||
}
|
||||
} else {
|
||||
logInfo('erp.notify.skip', { orderId, reason: 'already_notified' })
|
||||
}
|
||||
|
|
@ -539,4 +550,4 @@ app.post('/api/payments/webhook', async (req, res) => {
|
|||
const port = process.env.PORT || 8000
|
||||
app.listen(port, () => {
|
||||
console.log(`[server] listening on http://localhost:${port}/ (production=${isProduction})`)
|
||||
})
|
||||
})
|
||||
|
|
|
|||
Loading…
Reference in New Issue